This updates Rubocop and uses the .rubocop_rspec_base.yml for consistency #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Jan 12, 2022
pirj
reviewed
Jan 12, 2022
| @@ -7,18 +7,18 @@ module Generators | |||
| class ScaffoldGenerator < Base | |||
| include ::Rails::Generators::ResourceHelpers | |||
| source_paths << File.expand_path('../helper/templates', __dir__) | |||
| argument :attributes, type: :array, default: [], banner: "field:type field:type" | |||
| argument :attributes, :type => :array, :default => [], :banner => "field:type field:type" | |||
There was a problem hiding this comment.
What if we disable the cop that finds hash rocket offensive, and move it to todo?
See previous discussion on RuboCop update and fixes:
There was a problem hiding this comment.
So we could move the cop that requires hash rocket out of the common base, and put it in todo for the repos that still need to support older Rubies. That would work. Then we could just revert the hash rocket changes here - this repo was using JSON-style syntax.
There was a problem hiding this comment.
What if we keep it in base, but set Enabled: false in todo? Will todo take precedence over base?
That way, base is still common across all repos and intact. And we reduce churn for this PR.
pirj
reviewed
Jan 12, 2022
pirj
force-pushed
the
feature/update_rubocop
branch
from
f067b85 to
a24a244
Compare
pirj
force-pushed
the
feature/update_rubocop
branch
from
a24a244 to
a994c16
Compare
|
Thank you, @petergoldstein ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.