Skip to content

Disallow failures for passing builds #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Conversation

pirj
Copy link
Member

@pirj pirj commented Oct 2, 2021

  1. Disallow failures for Rails 6.1 on Ruby 3.0

Both are pretty stable, and the build actually passes
https://github.com/rspec/rspec-rails/runs/3771356606

  1. Turn pending test to a regular one for Rails 5.2

ActiveSupport::Cache::RedisCacheStore's usage of safe navigation was fixed in Rails 5.2.5:
https://github.com/rails/rails/blob/v5.2.4.3/activesupport/lib/active_support/cache/redis_cache_store.rb#L323
https://github.com/rails/rails/blob/v5.2.5/activesupport/lib/active_support/cache/redis_cache_store.rb#L323

In ActionDispatch::Request::Session it was fixed, too:
https://github.com/rails/rails/blob/v5.2.4.3/actionpack/lib/action_dispatch/request/session.rb#L96
https://github.com/rails/rails/blob/v5.2.5/actionpack/lib/action_dispatch/request/session.rb#L96

Our pending was actually failing (since the test was passing) for some while:

 Failures:

  1) RSpec::Rails::ViewExampleGroup#view is accessible to configuration-level hooks FIXED
     Expected pending '
          Rails 5.2.4.2 has a syntax error in ActionDispatch::Request::Session.
          (A &. usage which does not work in 2.2.10)
          It has been fixed but not released, this spec will not pass until that
          has been released.
        ' to fail. No error was raised.
     # ./spec/rspec/rails/example/view_example_group_spec.rb:254

❓ Do we need to keep the build for 5-2-stable?

@pirj pirj self-assigned this Oct 2, 2021
@pirj pirj requested review from JonRowe and benoittgt October 2, 2021 19:56
@JonRowe JonRowe merged commit fdcd1df into main Oct 4, 2021
@JonRowe JonRowe deleted the revive-rails5.2-build-on-ruby-2.2 branch October 4, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants