Disallow failures for passing builds #2524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are pretty stable, and the build actually passes
https://github.com/rspec/rspec-rails/runs/3771356606
ActiveSupport::Cache::RedisCacheStore's usage of safe navigation was fixed in Rails 5.2.5:
https://github.com/rails/rails/blob/v5.2.4.3/activesupport/lib/active_support/cache/redis_cache_store.rb#L323
https://github.com/rails/rails/blob/v5.2.5/activesupport/lib/active_support/cache/redis_cache_store.rb#L323
In ActionDispatch::Request::Session it was fixed, too:
https://github.com/rails/rails/blob/v5.2.4.3/actionpack/lib/action_dispatch/request/session.rb#L96
https://github.com/rails/rails/blob/v5.2.5/actionpack/lib/action_dispatch/request/session.rb#L96
Our
pending
was actually failing (since the test was passing) for some while:❓ Do we need to keep the build for
5-2-stable
?