Skip to content

Disallow failures for passing builds #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Disallow failures for passing builds #2524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b8fffe
Turn pending test to a regular one for Rails 5.2
pirj Oct 2, 2021
72fc8aa
Disallow failures for Rails 6.1 on Ruby 3.0
pirj Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:

# Rails 6.1 builds >= 2.5
- ruby: 3.0
allow_failure: true
env:
RAILS_VERSION: '~> 6.1.0'
- ruby: 2.7
Expand Down Expand Up @@ -68,7 +67,6 @@ jobs:
env:
RAILS_VERSION: '~> 5.2.0'
- ruby: 2.2.10
allow_failure: true
env:
RAILS_VERSION: '~> 5.2.0'
- ruby: 2.2.10
Expand Down
13 changes: 1 addition & 12 deletions spec/rspec/rails/example/view_example_group_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,19 +239,8 @@ def _view; end # Stub method
expect(view_spec.view).to eq(view)
end

if RUBY_VERSION <= "2.3.0" && ENV["RAILS_VERSION"] !~ /stable/ && ::Rails.version.to_f == 5.2
pending_only_on_ruby_22_rails_52 = """
Rails 5.2.4.2 has a syntax error in ActionDispatch::Request::Session.
(A &. usage which does not work in 2.2.10)
It has been fixed but not released, this spec will not pass until that
has been released.
"""
else
pending_only_on_ruby_22_rails_52 = false
end

# Regression test from rspec/rspec-rails#833
it 'is accessible to configuration-level hooks', pending: pending_only_on_ruby_22_rails_52 do
it 'is accessible to configuration-level hooks' do
run_count = 0
RSpec.configuration.before(:each, type: :view) do
# `view` is provided from the view example type, and serves to
Expand Down