This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Differentiate between block args with defaults and without. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| obj = Object.new | ||
| obj.define_singleton_method(:to_lambda, &block) | ||
| obj.method(:to_lambda).to_proc |
There was a problem hiding this comment.
to_lambda to_proc? Can you elaborate how this works?
There was a problem hiding this comment.
Methods and lambdas share semantics in terms of how return works and how they handle arguments. To convert a proc to a lambda on MRI, we need to define a method using the proc, and then, use Method#to_proc to get back proc that's a lambda proc.
I just chose to_lambda as the name for the method but it doesn't really matter what it's named.
There was a problem hiding this comment.
Ah I see, so to_proc actually returns a lambda ok, thanks :)
|
I'm curious about how the implementation works but it looks good to me, considering the build passes. |
myronmarston
added a commit
that referenced
this pull request
Jun 19, 2014
Differentiate between block args with defaults and without.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rspec/rspec-mocks#714.