This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove proc_to_lambda.
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a very odd ruby bug that makes this unsafe to use, as its usage mutates the behavior of the block: https://bugs.ruby-lang.org/issues/9967 Unfortunately, this un-fixes rspec/rspec-mocks#714, but we've got to do it.
|
This is failing an rspec-mocks spec that depends upon the old behavior. The spec is made pending in rspec/rspec-mocks#721(which is green against this branch). There's a chicken-and-egg problem here so I'd like to go ahead and merge this branch even though it's red. Can someone review this? I'd like to get rspec-support 3.0.2 out ASAP with this since 3.0.1 had a regression here. |
|
Can we not dup the block to avoid the mutation? |
|
I tried both dup and clone, and the bug remains. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a very odd ruby bug that makes this unsafe to use, as its
usage mutates the behavior of the block:
https://bugs.ruby-lang.org/issues/9967
Unfortunately, this un-fixes rspec/rspec-mocks#714, but we've got to do it.