-
Notifications
You must be signed in to change notification settings - Fork 53
TypeScript implementation #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@whyboris looks good. I need to get some time to test it. |
No rush -- and I'm happy to work more on this -- let me know if you have any recommended direction (especially if different than what I've done) 👍 |
@whyboris noticed some changes required:
and overall I would prefer to move all files to TS and enable a couple more settings in the end to enforce types and best practices. |
@whyboris noticed some changes required:
and overall I would prefer to move all files to TS and enable a couple more settings in the end to enforce types and best practices. |
Sorry I dropped out after I opened this PR 😅 was a bit busy 😄 |
Closing for #53 |
This is a sample start on what a TypeScript implementation would look like.
Discussion: #46
The key benefit of TypeScript here is strict typing of method arguments.
Other changes:
opn
instead ofopen
(deprecated)If TypeScript were to be implemented, the release procedures would need to change somewhat (it's the built files that need to be a part of the CLI, not the original TypeScript files).
If idea is approved, before release I would:
scripts
(e.g.yarn test
would runyarn build
first)