Skip to content

Move to Typescript #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 25, 2019
Merged

Move to Typescript #53

merged 15 commits into from
Aug 25, 2019

Conversation

rtfpessoa
Copy link
Owner

Based on #47

@rtfpessoa rtfpessoa force-pushed the whyboris-testing branch 2 times, most recently from 42908b5 to 725f65d Compare August 23, 2019 23:57
@rtfpessoa
Copy link
Owner Author

@whyboris I did some changes to have everything in TS with Jest.
What do you think?

@rtfpessoa rtfpessoa force-pushed the whyboris-testing branch 4 times, most recently from 1d07c79 to 3cb950a Compare August 24, 2019 00:03
@whyboris
Copy link
Contributor

Beautiful! I pulled in this branch, installed the new dependencies, ran npm test and saw Jest do its thing 💯

Thank you for finalizing what I started 🙇

Cheers 🙌

Copy link
Contributor

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚀 😁

@whyboris
Copy link
Contributor

Will close #46

@whyboris
Copy link
Contributor

By the way, just so you know -- I have an alias on my machine

alias diff='diff2html -s side --ig package-lock.json'

Which I run every time before I create a commit - to see just what I'm about to commit 👍

Thank you again for your superbly-useful CLI 🙇

@rtfpessoa rtfpessoa force-pushed the whyboris-testing branch 3 times, most recently from 85c9d6f to f7902a3 Compare August 25, 2019 22:44
@rtfpessoa rtfpessoa force-pushed the whyboris-testing branch 4 times, most recently from 2ce038f to 3d0c395 Compare August 25, 2019 23:02
@rtfpessoa
Copy link
Owner Author

I did some more touches to enforce even more types.
Now I think I have a good idea of what is needed to do in the diff2html base.

@whyboris thanks a lot for your initial work and help to make this possible.

@rtfpessoa rtfpessoa merged commit d735cf5 into master Aug 25, 2019
@rtfpessoa rtfpessoa deleted the whyboris-testing branch August 25, 2019 23:13
@rtfpessoa
Copy link
Owner Author

Released as version 4.0.0

@whyboris whyboris mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants