Bug fixes to 0.9.0 #168
Bug fixes to 0.9.0 #168
Conversation
* Connection#search now does more graceful nil-checking in its ensure clause, reducing cryptic crash messages * Filter class methods should now be able to gracefully accept numeric literals as filter rhs values
| right.to_s | ||
| else | ||
| raise ArgumentError, "Did not know how to convert argument \"#{right}\" into the rhs of an LDAP filter" | ||
| end |
There was a problem hiding this comment.
I'd be comfortable with always calling right.to_s.gsub instead of introducing conditional branching.
There was a problem hiding this comment.
Also, add a simple test to make sure this works! :)
|
Thanks for the bugfixes @WoodsBagotAndreMarquesLee! Really appreciate you taking the time and expending the effort to help out. I notice that this PR is open against the |
|
@WoodsBagotAndreMarquesLee hey there, any chance you could rebase this off of master and submit as a new PR? I can't accept this against the |
|
Superseded by #184 |
…nescape Rebase #168: Connection#unescape handles numerics, #search guards against nil queued_reads
…numeric-unescape Rebase ruby-ldap#168: Connection#unescape handles numerics, #search guards against nil queued_reads
Hey, I just fixed up a couple of the little issues I had when I tried to use your gem out-of-the-box. For what it's worth, it's entirely possible that I only encountered the nil-checking bug because one of my co-workers was messing around with our LDAP server while I was composing and testing my search query, it might not be a problem when working with an operational server.
Implemented a couple of bug fixes: