New filter type to allow searching of binary data #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NOT force convert data to UTF-8. This is required for proper binary data filters in Microsoft Active Directory.
|
I ran into another issue with Active Directory when doing searches... |
THANK YOU!took me forever to find anything that allowed me to query on objectguid. The only thing that was working before this was ruby 1.8.7 and ruby-net-ldap 0.0.4 :) thanks. |
|
any reason why this hasn't been merged in yet? |
|
Will this be merged? |
RoryO
pushed a commit
that referenced
this pull request
Aug 28, 2012
New filter type to allow searching of binary data
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
New filter type to allow searching of binary data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to implement this. Another option would be to not throw an exception if a string can't be converted into UTF-8 and silently pass it along. I think creating a specific filter type when searching for non-standard data is the safer option.
I added a test to make sure binary data is represented properly.
This resolves issue #30, although would require application code to be re-written to use the new filter.
It's very important that Microsoft Active Directory can be searched for binary data, as this is the only way to search for GUIDs.