Fall back if string cannot be encoded #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worked for me... |
RoryO
pushed a commit
that referenced
this pull request
Aug 28, 2012
Fall back if string cannot be encoded
Closed
satoryu
pushed a commit
to satoryu/ruby-net-ldap
that referenced
this pull request
Mar 13, 2013
1. String#encode should not fail if given an invalid code like '\x81' This is because this problem has been resolved by ruby-ldap#41. 2. Net::LDAP#search should return a boolean if return_result is false.
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
Fall back if string cannot be encoded
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
1. String#encode should not fail if given an invalid code like '\x81' This is because this problem has been resolved by ruby-ldap#41. 2. Net::LDAP#search should return a boolean if return_result is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes searching for "(objectclass=user)" on my ActiveDirectory behave itself. Something in the LDAP directory was failing terribly, which was allowing searches by "(cn=[a-z]*)", but would fail on a filter for "(objectclass=user)".
This quick'n'dirty patch resolved my issue.
I use it in combination with Pull Request 33 (#33).