-
Notifications
You must be signed in to change notification settings - Fork 152
Separate functional specifications into own CI job #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5957e6
to
f28413f
Compare
932e867
to
f0a81de
Compare
nwatson22
approved these changes
Jun 28, 2024
rv-jenkins
pushed a commit
to runtimeverification/haskell-backend
that referenced
this pull request
Jul 1, 2024
runtimeverification/evm-semantics#2504 has renamed the `test-prove-pyk` Makefile target to `test-prove-rules`. This PR now runs this target when evaluating KEVM performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see a lot of flakiness on proofs due to resource exhaustion or timeouts and such. In particular, our funcitonal specifications flake frequently, because they have many claims in the same file and it only takes one claim flaking to cause the whole proof-suite to flake. This PR separates them into their own CI job for faster re-running.
test_pyk_prove
is renamed to_test_prove
and made to be callable in multiple contexts.test_prove_rules
andtest_prove_functional
are added, which segment the test-suite and call each separately.Makefile
.ALL_TESTS
is resolved.test_prove_dss
to use new_test_prove
as well.test_prove.py
a bit.