Skip to content

Separate functional specifications into own CI job #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 28, 2024

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Jun 26, 2024

We see a lot of flakiness on proofs due to resource exhaustion or timeouts and such. In particular, our funcitonal specifications flake frequently, because they have many claims in the same file and it only takes one claim flaking to cause the whole proof-suite to flake. This PR separates them into their own CI job for faster re-running.

  • The test_pyk_prove is renamed to _test_prove and made to be callable in multiple contexts.
  • The test_prove_rules and test_prove_functional are added, which segment the test-suite and call each separately.
  • CI job is updated to use this disntiction, and the Makefile.
  • Some issue with how we computed ALL_TESTS is resolved.
  • Refactors test_prove_dss to use new _test_prove as well.
  • Organizes file test_prove.py a bit.
  • Decrease the timeout for running the rule proofs on booster from 150m => 100m (takes ~60m on CI).

@ehildenb ehildenb force-pushed the separate-functional branch from 932e867 to f0a81de Compare June 28, 2024 15:25
@ehildenb ehildenb marked this pull request as ready for review June 28, 2024 16:48
@ehildenb ehildenb requested review from nwatson22 and anvacaru June 28, 2024 16:49
@rv-jenkins rv-jenkins merged commit 1060bfe into master Jun 28, 2024
13 checks passed
@rv-jenkins rv-jenkins deleted the separate-functional branch June 28, 2024 19:02
rv-jenkins pushed a commit to runtimeverification/haskell-backend that referenced this pull request Jul 1, 2024
runtimeverification/evm-semantics#2504 has
renamed the `test-prove-pyk` Makefile target to `test-prove-rules`. This
PR now runs this target when evaluating KEVM performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants