Skip to content

Rename test-stages, improve parallel parameterization #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Jun 27, 2024

Pulled out of: #2504

The goal here is to make it so that the profo test names are more stable across changes. Currently, the test parameters in the matrix are included in the names, which means that adjusting timeouts and such requires an update to the required status checks. Also currently, the status check names are really long, and all start with "Test PR / Build and Test KEVM ...", which means that the text runs out of the little display window we get for the names.

This PR:

  • Adjusts the test names to be shorter and more descriptive, and not contain test parameter information.

  • Parameterizes the proof tests in how many parallel executions to run.

  • TODO Update required status checks.

@ehildenb ehildenb self-assigned this Jun 27, 2024
@ehildenb
Copy link
Member Author

Before:
image

After:
image

@ehildenb ehildenb marked this pull request as ready for review June 28, 2024 15:10
@ehildenb ehildenb requested review from anvacaru and nwatson22 June 28, 2024 15:10
@ehildenb ehildenb merged commit 9d3c329 into master Jun 28, 2024
12 checks passed
@ehildenb ehildenb deleted the rename-test-stages branch June 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants