Skip to content

Removes sort checks for Map and Set during internalization #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

emarzion
Copy link
Contributor

@emarzion emarzion commented Mar 5, 2021

Fixes #2376

  • Removes isMapSort/isSetSort check from Map.internalize/Set.internalize
  • Removes SmtMetadataTools argument from Map.internalize/Set.internalize

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@emarzion emarzion force-pushed the remove-sort-checks branch from 54fa317 to 52c20f1 Compare March 10, 2021 02:37
@emarzion emarzion marked this pull request as ready for review March 10, 2021 15:34
@emarzion emarzion changed the title Removing sort checks for Map and Set during internalization Removes sort checks for Map and Set during internalization Mar 11, 2021
@ttuegel ttuegel requested a review from MirceaS March 11, 2021 15:33
@emarzion emarzion merged commit 4195d94 into master Mar 11, 2021
@emarzion emarzion deleted the remove-sort-checks branch March 11, 2021 23:08
MirceaS added a commit that referenced this pull request Mar 15, 2021
rv-jenkins added a commit that referenced this pull request Mar 16, 2021
…ges (#2463)

* Revert "Removes sort checks for Map and Set during internalization (#2440)"

This reverts commit 4195d94.

* Revert "Use unit and element symbol attributes"

This reverts commit abf0292.

* Materialize Nix expressions

* removed issue-2095 tests

Co-authored-by: MirceaS <[email protected]>
Co-authored-by: rv-jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore sorts when converting terms to internal representations
2 participants