Skip to content

Issue 2100 followup #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 72 commits into from
Closed

Issue 2100 followup #2573

wants to merge 72 commits into from

Conversation

MirceaS
Copy link
Contributor

@MirceaS MirceaS commented Apr 25, 2021

PR #2168 was merged before I could address the last review comments so this PR is meant to do that.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@MirceaS MirceaS requested a review from ttuegel April 25, 2021 14:27
@MirceaS MirceaS closed this Apr 25, 2021
@MirceaS MirceaS deleted the issue-2100-followup branch April 25, 2021 14:33
@MirceaS
Copy link
Contributor Author

MirceaS commented Apr 25, 2021

PR closed in favour of PR #2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants