Skip to content

Issue 2100 follow up #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

Issue 2100 follow up #2574

merged 1 commit into from
Apr 26, 2021

Conversation

MirceaS
Copy link
Contributor

@MirceaS MirceaS commented Apr 25, 2021

PR #2168 was merged before I could address the last review comments so this PR is meant to do that.

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@MirceaS MirceaS requested a review from ttuegel April 25, 2021 14:34
@MirceaS MirceaS mentioned this pull request Apr 25, 2021
Closed
4 tasks
@rv-jenkins rv-jenkins merged commit 9733608 into master Apr 26, 2021
@rv-jenkins rv-jenkins deleted the issue-2100-addon branch April 26, 2021 14:49
ttuegel added a commit that referenced this pull request Apr 29, 2021
@ttuegel
Revert "Issue 2100 follow up (#2574)"
97494af 
This reverts commit 9733608.
@ttuegel ttuegel mentioned this pull request Apr 29, 2021
Merged
4 tasks
ttuegel added a commit that referenced this pull request May 2, 2021
@ttuegel
Replay "Issue 2100 follow up (#2574)"
73a6f3d 
This reverts commit 97494af.
rv-jenkins pushed a commit that referenced this pull request May 9, 2021
@ttuegel @MirceaS
Validate functions (#2585)
8cf981d 
* Replay "Validate function definitions (#2168)"

This reverts commit 8782a70.

* Trim source paths from regression tests

* Replay "Issue 2100 follow up (#2574)"

This reverts commit 97494af.

* Added another case for \or patterns

Co-authored-by: Octavian Mircea Sebe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MirceaS @ttuegel @rv-jenkins