Skip to content

Revert function validation #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Revert function validation #2582

merged 6 commits into from
Apr 29, 2021

Conversation

ttuegel
Copy link
Contributor

@ttuegel ttuegel commented Apr 29, 2021

Revert #2168.
Revert #2574.
Revert #2575.

The integration test in test/regression-c-semantics was silently failing on master due to these changes.

Because of the difficulty synchronizing the frontend with our prelude.kore, I will keep the changes to that file; the changes were backwards-compatible anyway.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel requested review from MirceaS and dopamane April 29, 2021 20:58
@ttuegel ttuegel marked this pull request as ready for review April 29, 2021 21:32
@ttuegel ttuegel merged commit b199d52 into master Apr 29, 2021
@ttuegel ttuegel deleted the revert-validate-functions branch April 29, 2021 23:58
@ttuegel ttuegel restored the revert-validate-functions branch April 30, 2021 20:07
@ana-pantilie ana-pantilie deleted the revert-validate-functions branch May 25, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants