Skip to content

Validate functions #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2021
Merged

Validate functions #2585

merged 5 commits into from
May 9, 2021

Conversation

ttuegel
Copy link
Contributor

@ttuegel ttuegel commented May 2, 2021

Reapply #2168.

It looks like we forgot \or patterns in function rules.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@MirceaS
Copy link
Contributor

MirceaS commented May 3, 2021

@ttuegel Do you mean like this?

@MirceaS
Copy link
Contributor

MirceaS commented May 4, 2021

@ttuegel
Copy link
Contributor Author

ttuegel commented May 5, 2021

This error will be fixed by #2598.

@ttuegel ttuegel marked this pull request as ready for review May 6, 2021 14:35
@ttuegel ttuegel requested a review from MirceaS May 6, 2021 14:37
@github-actions
Copy link

github-actions bot commented May 6, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sumTo10.sh 0.000033 -0.020098
test/regression-evm/test-add0.sh 0.000550 -0.000165
test/regression-evm/test-straight-line-no-invalid.sh 0.000790 -0.000199
test/regression-evm/test-pop1.sh 0.000744 -0.000157
test/regression-evm/test-straight-line.sh 0.000737 -0.000259
test/regression-evm/test-branching-invalid.sh 0.000572 -0.000300
test/regression-evm/test-branching-no-invalid.sh 0.000607 -0.000401
test/regression-evm/test-sum-to-n.sh 0.000115 0.008357
test/regression-wasm/test-loops.sh 0.000335 -0.000061
test/regression-wasm/test-wrc20.sh 0.000073 0.011767
test/regression-wasm/test-simple-arithmetic.sh 0.001037 -0.000535
test/regression-wasm/test-memory.sh 0.000655 0.000040
test/regression-wasm/test-locals.sh 0.001198 0.000768

@rv-jenkins rv-jenkins merged commit 8cf981d into master May 9, 2021
@rv-jenkins rv-jenkins deleted the validate-functions branch May 9, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants