Skip to content

Remove support for C semantics #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Remove support for C semantics #2598

merged 1 commit into from
May 5, 2021

Conversation

ttuegel
Copy link
Contributor

@ttuegel ttuegel commented May 5, 2021

This pull request removes regression tests related to the C semantics from our repository.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel requested a review from MirceaS May 5, 2021 21:14
@ttuegel ttuegel mentioned this pull request May 5, 2021
4 tasks
@ttuegel
Copy link
Contributor Author

ttuegel commented May 5, 2021

This is because the backend lacks proper support for +Int patterns on the left-hand side of rules, particularly in Map keys.

@rv-jenkins rv-jenkins merged commit 9686e3c into master May 5, 2021
@rv-jenkins rv-jenkins deleted the remove-c-semantics branch May 5, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants