Fix 'm' not displayed in uppercase (azerty) #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcazef
changed the title
vinc
reviewed
Aug 4, 2021
| @@ -324,7 +324,9 @@ impl KeyboardLayout for Azerty { | |||
| } | |||
| } | |||
| KeyCode::SemiColon => { | |||
| if modifiers.is_shifted() { | |||
| if map_to_unicode && modifiers.is_ctrl() { | |||
| DecodedKey::Unicode('\u{000D}') | |||
There was a problem hiding this comment.
The layout would then have two keys producing \u000D with ctrl because of KeyCode::M. I think your change is correct and KeyCode::M should not produce \u000D on azerty. What do you think?
There was a problem hiding this comment.
I agree that this key should produce Ctrl-M (0x0D) when pressed with the Control modifier. The 0x0D on line 397 does need removing though.
thejpster
requested changes
Oct 15, 2021
|
Thank you for this PR. I spotted one other bug in my code that we should clean up at the same time! |
Merged
|
This PR can be closed now that the other one has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On azerty layout, capslock + "M" was decoded as a lowercase "m".