Skip to content

Fix CTRL codes on AZERTY #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

vinc
Copy link
Contributor

@vinc vinc commented Sep 17, 2022

I looked at the AZERTY code again and found other issues related to #10 that needed more changes.

Some CTRL codes associated with the letter keys were the same as on a QWERTY keyboard instead of being remapped to where they should be on an AZERTY keyboard.

I tested the changes on the text editor of MOROS where some shortcuts (^Q and ^W for example) where not working before the fix.

All the codes from 0x0001 to 0x001A are here without duplicates:

> grep "Unicode.'.u{" src/layouts/azerty.rs | sort
                    DecodedKey::Unicode('\u{0001}')
                    DecodedKey::Unicode('\u{0002}')
                    DecodedKey::Unicode('\u{0003}')
                    DecodedKey::Unicode('\u{0004}')
                    DecodedKey::Unicode('\u{0005}')
                    DecodedKey::Unicode('\u{0006}')
                    DecodedKey::Unicode('\u{0007}')
                    DecodedKey::Unicode('\u{0008}')
                    DecodedKey::Unicode('\u{0009}')
                    DecodedKey::Unicode('\u{000A}')
                    DecodedKey::Unicode('\u{000B}')
                    DecodedKey::Unicode('\u{000C}')
                    DecodedKey::Unicode('\u{000D}')
                    DecodedKey::Unicode('\u{000E}')
                    DecodedKey::Unicode('\u{000F}')
                    DecodedKey::Unicode('\u{0010}')
                    DecodedKey::Unicode('\u{0011}')
                    DecodedKey::Unicode('\u{0012}')
                    DecodedKey::Unicode('\u{0013}')
                    DecodedKey::Unicode('\u{0014}')
                    DecodedKey::Unicode('\u{0015}')
                    DecodedKey::Unicode('\u{0016}')
                    DecodedKey::Unicode('\u{0017}')
                    DecodedKey::Unicode('\u{0018}')
                    DecodedKey::Unicode('\u{0019}')
                    DecodedKey::Unicode('\u{001A}')

@thejpster
Copy link
Member

Thanks!

@thejpster thejpster merged commit 19d9e50 into rust-embedded-community:main Oct 6, 2022
@vinc vinc deleted the fix/azerty-ctrl branch October 7, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants