Skip to content

add de104 keyboard layout #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Oct 16, 2021
Merged

add de104 keyboard layout #13

merged 3 commits into from Oct 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 23, 2021

adds the german keyboard layout

@vinc
Copy link
Contributor

vinc commented Aug 4, 2021

Hello, I tested your layout in MOROS and every chars that my OS can print looks good, including ä, ö, and ü, but the < key at the bottom left of that image doesn't produce anything: https://en.wikipedia.org/wiki/File:KB_Germany.svg

I think the following PR had the same issue: #8

Does that key work for you @kevtechXx?

@ghost
Copy link
Author

ghost commented Aug 5, 2021

Nope it also doesn't work for me.
On german keyboards the < key returns keycode 0x56 which doesn't get decoded by both ScancodeSet1 and ScancodeSet2 :/

@thejpster
Copy link
Member

thejpster commented Oct 15, 2021

I believe the fix is to change

and emit a new enumerator called something like KeyCode::Oem102. You can then check for that keycode and emit <, > or | as appropriate.

@thejpster
Copy link
Member

thejpster commented Oct 15, 2021

The name OEM 102 was taken from https://kbdlayout.info/kbdgr/scancodes

@thejpster
Copy link
Member

Also, thank you for the PR!

@thejpster thejpster merged commit 5449f09 into rust-embedded-community:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants