start of Azerty layout scancode set2 #8

le0kar0ub1 · 2020-06-26T08:18:06Z

Basic Azerty layout handling.
The method used for other layouts occult the azerty meaning.

vinc · 2020-07-03T22:16:58Z

Hi, I have a French azerty keyboard on my laptop so I tested your branch on my little OS (https://github.com/vinc/moros), and the letters and numbers work fine but I had trouble with some other keys.

For example the < key at the bottom left of the keyboard doesn't work, while the * key on the right behave as if it was the < key. Are they working correctly for you? The issue could very well come from my OS though.

le0kar0ub1 · 2020-07-03T22:35:24Z

Hi, I will check this tomorrow and give you a feedback and then commit if the error come from me.

…

On Sat, Jul 4, 2020, 12:17 AM Vincent Ollivier ***@***.***> wrote: Hi, I have a French azerty keyboard on my laptop so I tested your branch on my little OS (https://github.com/vinc/moros), and the letters and numbers work fine but I had trouble with some other keys. For example the < key at the bottom left of the keyboard doesn't work, while the * key on the right behave as if it was the < key. Are they working correctly for you? The issue could very well comes from my OS though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLNLGTEU63GOZPZYV4MDILRZZKGNANCNFSM4OJDKRYA> .

le0kar0ub1 · 2020-07-04T11:26:16Z

hi again, Are we okay on the basic layout implementation ? us104 - > https://upload.wikimedia.org/wikipedia/commons/3/3a/Qwerty.svg Ideally i think that to be coherent on the translation to azerty layout, a new KeyCode implementation can be a more efficient way. Btw, as a first step i will re-map correctly when i will be certain that the basic keyboard layout is the one i showed above. If im mistaken, can you transfer me an image to the well layout please ? Le sam. 4 juil. 2020 à 00:17, Vincent Ollivier <[email protected]> a écrit :

…

Hi, I have a French azerty keyboard on my laptop so I tested your branch on my little OS (https://github.com/vinc/moros), and the letters and numbers work fine but I had trouble with some other keys. For example the < key at the bottom left of the keyboard doesn't work, while the * key on the right behave as if it was the < key. Are they working correctly for you? The issue could very well comes from my OS though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLNLGTEU63GOZPZYV4MDILRZZKGNANCNFSM4OJDKRYA> .

vinc · 2020-07-04T15:50:28Z

The US Qwerty keyboard layout is 104 keys, and the UK one is 105 keys. I think the common French Azerty keyboard is 105 keys like the UK one, so it might help to reuse Uk105Key and code only what is changing between those two.

https://upload.wikimedia.org/wikipedia/commons/d/da/KB_United_States.svg
https://upload.wikimedia.org/wikipedia/commons/d/da/KB_United_Kingdom.svg

That's what I did when I implemented the Dvorak layout from Us104Key as you can see here: https://github.com/rust-embedded-community/pc-keyboard/pull/6/files#diff-ec45777dbfe740feab6d8d88592c97d1R297

vinc · 2020-07-04T15:55:44Z

You made me realize that actually I should also have started from Uk105Key to have the bottom left key working on a Dvorak 105 keys keyboard!

le0kar0ub1 · 2020-07-05T13:25:19Z

hi, I think the keymap must be okay except for the ['<' '>']. I don't understand how the UK keyboard key ['|' '\'] can work, have you tested it ? These 2 keys trigger the same KeyCode on azerty/UK then, if it's work on the UK this will work on the azerty. Btw, the rest of the map should work fine. Le sam. 4 juil. 2020 à 17:55, Vincent Ollivier <[email protected]> a écrit :

…

You made me realize that actually I should also have started from Uk105Key to have the bottom left < key working on a Dvorak 105 keys keyboard! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLNLGWB5AJRLZGG57UNEOTRZ5GIXANCNFSM4OJDKRYA> .

le0kar0ub1 · 2020-07-05T13:26:40Z

I havn't pull request, the code is updated on my forked version. Le dim. 5 juil. 2020 à 15:25, Leo K <[email protected]> a écrit :

…

hi, I think the keymap must be okay except for the ['<' '>']. I don't understand how the UK keyboard key ['|' '\'] can work, have you tested it ? These 2 keys trigger the same KeyCode on azerty/UK then, if it's work on the UK this will work on the azerty. Btw, the rest of the map should work fine. Le sam. 4 juil. 2020 à 17:55, Vincent Ollivier ***@***.***> a écrit : > You made me realize that actually I should also have started from > Uk105Key to have the bottom left < key working on a Dvorak 105 keys > keyboard! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#8 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANLNLGWB5AJRLZGG57UNEOTRZ5GIXANCNFSM4OJDKRYA> > . >

vinc

I tested all the ASCII chars on my OS, and everything is working perfectly except 2 keys (! and =) where the lowercase and uppercase chars should be swapped.

vinc · 2020-07-09T20:30:28Z

src/layouts/azerty.rs

+            }
+            KeyCode::Slash => {
+                if modifiers.is_shifted() {
+                    DecodedKey::Unicode('!')


Suggested change

DecodedKey::Unicode('!')

DecodedKey::Unicode('§')

vinc · 2020-07-09T20:33:04Z

src/layouts/azerty.rs

+            }
+            KeyCode::Equals => {
+                if modifiers.is_shifted() {
+                    DecodedKey::Unicode('=')


Suggested change

DecodedKey::Unicode('=')

DecodedKey::Unicode('+')

vinc · 2020-07-09T20:33:16Z

src/layouts/azerty.rs

+                } else if modifiers.alt_gr {
+                    DecodedKey::Unicode('}')
+                } else {
+                    DecodedKey::Unicode('+')


Suggested change

DecodedKey::Unicode('+')

DecodedKey::Unicode('=')

vinc · 2020-07-09T20:38:32Z

src/layouts/azerty.rs

+                if modifiers.is_shifted() {
+                    DecodedKey::Unicode('!')
+                } else {
+                    DecodedKey::Unicode('§')


Suggested change

DecodedKey::Unicode('§')

DecodedKey::Unicode('!')

vinc

Looks good to me 👍

le0kar0ub1 · 2020-07-09T21:32:47Z

let's go :)

vinc · 2020-07-09T21:33:41Z

@thejpster could you have a look at this PR?

It would be great to publish a new version of the crate after that with the new layouts 🎉

thejpster · 2020-07-17T20:31:14Z

I no longer have write access to this repo I'm afraid.

thejpster · 2020-07-17T20:33:42Z

I see I am the only person who can push to crates.io though - who would like to be added to that, and can I add a Github group to a crate?

thejpster · 2020-07-17T20:41:09Z

OK, once rust-embedded-community/meta#2 is sorted, I can set the owner of pc-keyboard to be that team, and anyone in that team can push you a new release.

vinc · 2020-07-17T20:48:39Z

That seems great 👍

le0kar0ub1 added 2 commits June 26, 2020 10:07

add azerty layout

1c146a6

add some tests

5fde1b0

fix azerty keymap

9c87e15

vinc suggested changes Jul 9, 2020

View reviewed changes

fix = and !

94656bf

vinc approved these changes Jul 9, 2020

View reviewed changes

thejpster merged commit 6fe3616 into rust-embedded-community:master Jul 19, 2020

vinc mentioned this pull request Aug 4, 2021

add de104 keyboard layout #13

Merged

start of Azerty layout scancode set2 #8

start of Azerty layout scancode set2 #8

Uh oh!

Conversation

le0kar0ub1 commented Jun 26, 2020

Uh oh!

vinc commented Jul 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

le0kar0ub1 commented Jul 3, 2020 via email

Uh oh!

le0kar0ub1 commented Jul 4, 2020 via email

Uh oh!

vinc commented Jul 4, 2020

Uh oh!

vinc commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

le0kar0ub1 commented Jul 5, 2020 via email

Uh oh!

le0kar0ub1 commented Jul 5, 2020 via email

Uh oh!

vinc left a comment

Choose a reason for hiding this comment

Uh oh!

vinc Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

vinc Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

vinc Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

vinc Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

vinc left a comment

Choose a reason for hiding this comment

Uh oh!

le0kar0ub1 commented Jul 9, 2020

Uh oh!

vinc commented Jul 9, 2020

Uh oh!

thejpster commented Jul 17, 2020

Uh oh!

thejpster commented Jul 17, 2020

Uh oh!

thejpster commented Jul 17, 2020

Uh oh!

vinc commented Jul 17, 2020

Uh oh!

Uh oh!

vinc commented Jul 3, 2020 •

edited

Loading

vinc commented Jul 4, 2020 •

edited

Loading