Skip to content

s/Xargo/Cargo/ #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2018
Merged

s/Xargo/Cargo/ #85

merged 2 commits into from
Apr 8, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Apr 8, 2018

No description provided.

@japaric
Copy link
Member Author

japaric commented Apr 8, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 8, 2018
85: s/Xargo/Cargo/ r=japaric a=japaric



Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 8, 2018

Canceled

@japaric
Copy link
Member Author

japaric commented Apr 8, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 8, 2018
85: s/Xargo/Cargo/ r=japaric a=japaric



Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 8, 2018

Build succeeded

@bors bors bot merged commit 5815cbb into master Apr 8, 2018
@japaric japaric deleted the bye-xargo branch April 8, 2018 21:20
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
85: [WIP] provide defaults for DefaultHandler and HardFault r=korken89 a=japaric

`exception!(HardFault, ..)` and `exception!(*, ..)` can now be omitted from
programs to pick up the default behavior of an infinite loop. Existing programs
that define these exception handlers will continue to work w/o any functional
change.

closes #72

--

Annoyances:

- The handlers can't be *just* an infinite loop because of rust-lang/rust#28728.
If we define the handlers as just `loop {}` they will become an abort (UDF)
instruction. And that would turn HardFault into infinite recursion. For that
reason I have made them into an infinite loop that does some side effect

- If you stick to the defaults then the symbol name of the default handler
changes from `DefaultHandler` (override) to `DefaultDefaultHandler` (default).
We can make these two names more similar but I think we can not prevent the
rename. Something similar happens with UserHardFault (which becomes
DefaultUserHardFault when not overridden).

cc @rust-embedded/cortex-m

Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant