Skip to content

Give tables in readmes a bit of padding and a border #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2017
Merged

Give tables in readmes a bit of padding and a border #1016

merged 1 commit into from
Aug 31, 2017

Conversation

carols10cents
Copy link
Member

Before:

before

After:

after

@carols10cents carols10cents mentioned this pull request Aug 26, 2017
Closed
@carols10cents
Copy link
Member Author

I got one thumbs up so I'm merging this. It's just CSS, what could go wrong? 👼

bors: r+

bors-voyager bot added a commit that referenced this pull request Aug 30, 2017
@bors-voyager
Merge #1016 #1023
59a4bd5 
1016: Give tables in readmes a bit of padding and a border r=carols10cents

Before:

<img width="253" alt="before" src="https://user-images.githubusercontent.com/193874/29745854-40021ae6-8a94-11e7-868c-80e5e350b6f2.png">

After:

<img width="278" alt="after" src="https://user-images.githubusercontent.com/193874/29745855-43dfb466-8a94-11e7-8e0e-e3fc5cb12b48.png">


1023: Add query to display recent_downloads on krates::show r=carols10cents

Additionally, we've updated the join for this data on krate::index to
use the new public API Diesel added for this in the most recent version,
and made sure that any other endpoints which *don't* include this data
are returning NULL instead of 0

/cc @natboehm
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Aug 31, 2017

Build succeeded

@bors-voyager bors-voyager bot merged commit 037e852 into rust-lang:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carols10cents @Turbo87