Add query to display recent_downloads on krates::show #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, we've updated the join for this data on krate::index to use the new public API Diesel added for this in the most recent version, and made sure that any other endpoints which *don't* include this data are returning NULL instead of 0
sgrif
force-pushed
the
sg-nb-include-recent-downloads-in-crates-show
branch
from
1ae716e to
c68f750
Compare
bors-voyager bot
added a commit
that referenced
this pull request
Aug 30, 2017
1016: Give tables in readmes a bit of padding and a border r=carols10cents Before: <img width="253" alt="before" src="https://user-images.githubusercontent.com/193874/29745854-40021ae6-8a94-11e7-868c-80e5e350b6f2.png"> After: <img width="278" alt="after" src="https://user-images.githubusercontent.com/193874/29745855-43dfb466-8a94-11e7-8e0e-e3fc5cb12b48.png"> 1023: Add query to display recent_downloads on krates::show r=carols10cents Additionally, we've updated the join for this data on krate::index to use the new public API Diesel added for this in the most recent version, and made sure that any other endpoints which *don't* include this data are returning NULL instead of 0 /cc @natboehm
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, we've updated the join for this data on krate::index to
use the new public API Diesel added for this in the most recent version,
and made sure that any other endpoints which don't include this data
are returning NULL instead of 0
/cc @natboehm