Skip to content

Remplace 32x32 PNG with SVG for GitHub mark #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Remplace 32x32 PNG with SVG for GitHub mark #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/team.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</h2>
</div>
{{#user-link user=model.team data-test-github-link=true}}
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark-32px.png"/>
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg"/>
{{/user-link}}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/templates/user.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{{ model.user.login }}
</h1>
{{#user-link user=model.user data-test-user-link=true}}
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark-32px.png"/>
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg"/>
{{/user-link}}
</div>

Expand Down
Binary file removed public/assets/GitHub-Mark-32px.png
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions public/assets/GitHub-Mark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/acceptance/team-page-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test('github link has image in team header', async function(assert) {
await visit('/teams/github:org:thehydroimpulse');

assert.dom('[data-test-heading] [data-test-github-link] img')
.hasAttribute('src', '/assets/GitHub-Mark-32px.png');
.hasAttribute('src', '/assets/GitHub-Mark.svg');
});

test('team organization details has github profile icon', async function(assert) {
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/user-page-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ test('github link has image in user header', async function(assert) {
await visit('/users/thehydroimpulse');

assert.dom('[data-test-heading] [data-test-user-link] img')
.hasAttribute('src', '/assets/GitHub-Mark-32px.png');
.hasAttribute('src', '/assets/GitHub-Mark.svg');
});

test('user details has github profile icon', async function(assert) {
Expand Down