Skip to content

Remplace 32x32 PNG with SVG for GitHub mark #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

SimonSapin
Copy link
Contributor

The PNG looks blurry on a high-resolution display.

This SVG is extracted with Inkscape from GitHub-Mark.ai from https://github.com/logos.

The PNG looks blurry on a high-resolution display.

This SVG is extracted with Inkscape from GitHub-Mark.ai
from https://github.com/logos.
@carols10cents
Copy link
Member

Your eyes and/or monitor are better than mine :)

bors: r+

bors-voyager bot added a commit that referenced this pull request Jan 4, 2018
1211: Remplace 32x32 PNG with SVG for GitHub mark r=carols10cents

The PNG looks blurry on a high-resolution display.

This SVG is extracted with Inkscape from `GitHub-Mark.ai` from https://github.com/logos.

1215: Revert "Merge #1194" r=carols10cents

While I still like the feature it self, the implementation currently has some issues (see #1209) that I wasn't aware of initially and are not quite as easy to fix. Since I'll be on vacation for the next weeks I won't have time to work on a proper solution for now, so IMHO the best solution is to revert the problematic behavior until this can be fixed correctly.

Resolves #1209

/cc @durka @Boscop
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jan 4, 2018

Build succeeded

@bors-voyager bors-voyager bot merged commit e110495 into rust-lang:master Jan 4, 2018
@SimonSapin SimonSapin deleted the svg branch January 4, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants