Start search while typing #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Dec 3, 2017
|
cool!! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 3, 2017
1194: Start search while typing r=carols10cents Similar to e.g. https://yarnpkg.com/ this PR changes the code to start the search while typing instead of having to click the <kbd>Enter</kbd> button. It also debounces the search task (250ms) to limit the amount of requests that are hitting the server.  /cc @carols10cents
Build succeeded |
|
N.B. this caused #1209 |
|
Ouch, thanks for reporting this. I'll have a look tomorrow. |
|
This breaks submitting to a new tab without changing the current view, which I do often when looking up multiple crates at once. |
|
Yes, there are a number of other disadvantages, like it's slow :) but I
doubt it'll be reverted so I wanted to point out the most obvious bug.
…On Thu, Dec 28, 2017 at 3:45 PM, Anthony Ramine ***@***.***> wrote:
This breaks submitting to a new tab without changing the current view,
which I do often when looking up multiple crates at once.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1194 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC3n8IzK5oH4e-zDATBbsZFqr3geR2nks5tE_35gaJpZM4QzrZL>
.
|
bors-voyager bot
added a commit
that referenced
this pull request
Jan 4, 2018
1211: Remplace 32x32 PNG with SVG for GitHub mark r=carols10cents The PNG looks blurry on a high-resolution display. This SVG is extracted with Inkscape from `GitHub-Mark.ai` from https://github.com/logos. 1215: Revert "Merge #1194" r=carols10cents While I still like the feature it self, the implementation currently has some issues (see #1209) that I wasn't aware of initially and are not quite as easy to fix. Since I'll be on vacation for the next weeks I won't have time to work on a proper solution for now, so IMHO the best solution is to revert the problematic behavior until this can be fixed correctly. Resolves #1209 /cc @durka @Boscop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to e.g. https://yarnpkg.com/ this PR changes the code to start the search while typing instead of having to click the Enter button. It also debounces the search task (250ms) to limit the amount of requests that are hitting the server.
/cc @carols10cents