Revert "Merge #1194" #1215
Merged
Revert "Merge #1194" #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😿 it happens. bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jan 4, 2018
1211: Remplace 32x32 PNG with SVG for GitHub mark r=carols10cents The PNG looks blurry on a high-resolution display. This SVG is extracted with Inkscape from `GitHub-Mark.ai` from https://github.com/logos. 1215: Revert "Merge #1194" r=carols10cents While I still like the feature it self, the implementation currently has some issues (see #1209) that I wasn't aware of initially and are not quite as easy to fix. Since I'll be on vacation for the next weeks I won't have time to work on a proper solution for now, so IMHO the best solution is to revert the problematic behavior until this can be fixed correctly. Resolves #1209 /cc @durka @Boscop
Build succeeded |
|
Thanks :) |
|
There certainly is, but having your searches in the history is actually a good thing, just not for every key stroke... |
|
Yes, I mean only do pushState on Enter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I still like the feature it self, the implementation currently has some issues (see #1209) that I wasn't aware of initially and are not quite as easy to fix. Since I'll be on vacation for the next weeks I won't have time to work on a proper solution for now, so IMHO the best solution is to revert the problematic behavior until this can be fixed correctly.
Resolves #1209
/cc @durka @Boscop