Fix frontend docker configuration in docker-compose #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend Docker image appears to be following a pretty standard Node convention of adding the package.json, running `npm install`, and then copying the rest of the application, which makes rebuilding new docker images much faster if there are no dependency changes. However, in the great `yarn` cleanup of 2017, `yarn install` was removed but the corresponding `npm install` was not added back. This means that when the frontend docker image tries to run ember, ember is not available because it was never installed.
When using `npm run start --proxy http://backend:8888`, `npm` interprets the `--proxy http://backend:8888` as a parameter that IT should parse, which means the parameter never gets to `ember serve`. Add a `--` in the middle so that `npm` knows not to parse that flag and instead pass it to `ember serve`.
bryanburgers
changed the title
npm install to frontend Docker
|
Awesome, thanks for the contribution @bryanburgers! @bors r+ |
|
📌 Commit 1c044be has been approved by |
bors
added a commit
that referenced
this pull request
Feb 24, 2019
Fix frontend docker configuration in docker-compose Fixes to frontend to make `docker-compose up` work again on a fresh clone. Two fixes need to happen: 1. `npm install` needs to run when building the docker container, so that all of the dependencies exist. 2. A slight change to the `docker-compose.yml` file to properly link up the frontend to the backend. --- *[Edit]: this previously consisted of only a single commit that looked at the frontend.Dockerfile file. As I continued trying to get an environment up, I noticed another fix that needed to be made and decided it was similar-enough in scope that it should be added to his pull request. The original description follows.* **Add `npm install` to frontend Docker** The frontend Docker image appears to be following a pretty standard Node convention of adding the package.json, running `npm install`, and then copying the rest of the application, which makes rebuilding new docker images much faster if there are no dependency changes. However, in the great `yarn` cleanup of 2017, `yarn install` was removed but the corresponding `npm install` was not added back. This means that when the frontend docker image tries to run ember, ember is not available because it was never installed.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to frontend to make
docker-compose upwork again on a fresh clone.Two fixes need to happen:
npm installneeds to run when building the docker container, so that all of the dependencies exist.docker-compose.ymlfile to properly link up the frontend to the backend.[Edit]: this previously consisted of only a single commit that looked at the frontend.Dockerfile file. As I continued trying to get an environment up, I noticed another fix that needed to be made and decided it was similar-enough in scope that it should be added to his pull request. The original description follows.
Add
npm installto frontend DockerThe frontend Docker image appears to be following a pretty standard Node
convention of adding the package.json, running
npm install, and thencopying the rest of the application, which makes rebuilding new docker
images much faster if there are no dependency changes.
However, in the great
yarncleanup of 2017,yarn installwas removedbut the corresponding
npm installwas not added back. This means thatwhen the frontend docker image tries to run ember, ember is not
available because it was never installed.