docker: use --locked-schema for diesel migrations #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `docker-compose up` to bring up everything for development, we mount the source directory as read-only so that changes can only happen on the host machine and not because of something that the code running in docker does. This read-only mount was causing problems because `patch`, called by `diesel migration run`, would try to write to the filesystem and fail. When bringing up a docker environment for the first time from a fresh clone, we expect that the schema.rs file is already pristine, and that we just need to run migrations. For that reason, use `diesel migration run`'s `--locked-schema` option to just run migrations. This change makes it so that a new contributor can clone the repo, run `docker-compose up`, and have an almost complete environment to poke at and start exploring. Fixes rust-lang#1631
|
This merge request and #1632 which I also opened are similar in scope – getting the docker-compose stuff into a working and usable state. Let me know if they should be combined into a single merge request. |
|
LGTM, thanks! @bors r+ |
|
📌 Commit ab399e2 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 24, 2019
…ibel docker: use --locked-schema for diesel migrations When using `docker-compose up` to bring up everything for development, we mount the source directory as read-only so that changes can only happen on the host machine and not because of something that the code running in docker does. This read-only mount was causing problems because `patch`, called by `diesel migration run`, would try to write to the filesystem and fail. When bringing up a docker environment for the first time from a fresh clone, we expect that the schema.rs file is already pristine, and that we just need to run migrations. For that reason, use `diesel migration run`'s `--locked-schema` option to just run migrations. This change makes it so that a new contributor can clone the repo, run `docker-compose up`, and have an almost complete environment to poke at and start exploring. Fixes #1631
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
docker-compose upto bring up everything for development,we mount the source directory as read-only so that changes can only
happen on the host machine and not because of something that the code
running in docker does.
This read-only mount was causing problems because
patch, called bydiesel migration run, would try to write to the filesystem and fail.When bringing up a docker environment for the first time from a fresh
clone, we expect that the schema.rs file is already pristine, and that
we just need to run migrations. For that reason, use
diesel migration run's--locked-schemaoption to just run migrations.This change makes it so that a new contributor can clone the repo, run
docker-compose up, and have an almost complete environment to poke atand start exploring.
Fixes #1631