Skip to content

Bump ember-router-scroll from 2.0.1 to 3.3.2 #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 9, 2020

Bumps ember-router-scroll from 2.0.1 to 3.3.2.

Changelog

Sourced from ember-router-scroll's changelog.

Changelog

  • Updating to th v3.0 series was due to removing scrollWhenPainted as a config option. Also, we fixed some hidden bugs with scheduling when to scroll to your last y position.

3.3.0

  • #246 Add Evented trigger didScroll

3.2.0

  • #244 Bring back scroll recursive

3.1.3

  • #242 Unique functions to scheduleOnce...follow up
  • #241 Prevent multiple calls on routeDidChange
  • #240 Missing setter for scrollWhenAfterRender

3.1.0

  • #239 Scroll when afterRender

3.0.0

  • #238 Upgrade ember-app-scheduler to v4.0.0
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Mar 9, 2020

☔ The latest upstream changes (presumably #2262) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from b277891 to 92ef9ce Compare March 9, 2020 11:04
@bors
Copy link
Contributor

bors commented Mar 20, 2020

☔ The latest upstream changes (presumably #2279) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 92ef9ce to 37e9d88 Compare March 20, 2020 13:47
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 37e9d88 to dc9d480 Compare March 30, 2020 12:02
@jtgeibel
Copy link
Member

jtgeibel commented Apr 4, 2020

This is failing on CI in ember dependency-lint. I don't see any newer versions of ember-qunit or @ember/test-helpers so I don't think it is possible to resolve this at this time. Maybe we can make a smaller bump to ember-router-scroll, or just wait. Any suggestions @Turbo87 or @locks?

> [email protected] lint:deps /home/runner/work/crates.io/crates.io
> ember dependency-lint

ember-test-waiters
Allowed: (any single version)
Found: 1.1.1, 2.0.0
cargo
├─┬ ember-qunit
│ └─┬ @ember/test-helpers
│   └── [email protected]
└─┬ ember-router-scroll
  └─┬ ember-app-scheduler
    └── [email protected]

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] lint:deps: `ember dependency-lint`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] lint:deps script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-03-30T12_03_55_515Z-debug.log
##[error]Process completed with exit code 1.

@Turbo87
Copy link
Member

Turbo87 commented Apr 4, 2020

yeah, I'm aware of the issue. it needs a few dependency updates in the ecosystem before we can do the update. the router scroll update is not urgent though or blocking anything so I'm fine with waiting until the issue is resolved. I'm actively pushing for the necessary changes though :)

@bors
Copy link
Contributor

bors commented Apr 6, 2020

☔ The latest upstream changes (presumably #2393) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from dc9d480 to e763e9d Compare April 6, 2020 11:30
@bors
Copy link
Contributor

bors commented Apr 10, 2020

☔ The latest upstream changes (presumably #2406) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from e763e9d to d139c80 Compare April 10, 2020 21:27
@bors
Copy link
Contributor

bors commented Apr 13, 2020

☔ The latest upstream changes (presumably #2417) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch 2 times, most recently from cff15c5 to 54af123 Compare April 13, 2020 12:36
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 54af123 to 5b680d3 Compare May 4, 2020 13:46
@bors
Copy link
Contributor

bors commented May 11, 2020

☔ The latest upstream changes (presumably #2506) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 5b680d3 to 2f0e00e Compare May 11, 2020 13:45
@bors
Copy link
Contributor

bors commented May 11, 2020

☔ The latest upstream changes (presumably #2509) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 2f0e00e to 3da6bdc Compare May 11, 2020 14:08
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 3da6bdc to cde05c0 Compare May 18, 2020 16:02
@bors
Copy link
Contributor

bors commented May 25, 2020

☔ The latest upstream changes (presumably #2526) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from cde05c0 to 8bbccfd Compare May 25, 2020 12:23
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 8bbccfd to bca6319 Compare May 25, 2020 18:15
@bors
Copy link
Contributor

bors commented May 25, 2020

☔ The latest upstream changes (presumably #2527) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from bca6319 to 21adaa6 Compare May 25, 2020 18:23
@bors
Copy link
Contributor

bors commented Jun 8, 2020

☔ The latest upstream changes (presumably #2545) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 21adaa6 to 54345ca Compare June 8, 2020 13:07
@bors
Copy link
Contributor

bors commented Jun 9, 2020

☔ The latest upstream changes (presumably #2561) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 54345ca to c1972cf Compare June 9, 2020 20:50
@bors
Copy link
Contributor

bors commented Jun 10, 2020

☔ The latest upstream changes (presumably #2566) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from c1972cf to 4d34cbf Compare June 10, 2020 20:43
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from 4d34cbf to fb0523e Compare July 6, 2020 19:29
@bors
Copy link
Contributor

bors commented Jul 20, 2020

☔ The latest upstream changes (presumably #2646) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from fb0523e to c519028 Compare July 20, 2020 20:32
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch from c519028 to 04670a3 Compare July 20, 2020 20:42
@dependabot-preview
Copy link
Contributor Author

Superseded by #2665.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/ember-router-scroll-3.3.2 branch August 2, 2020 22:28
@bors
Copy link
Contributor

bors commented Aug 2, 2020

☔ The latest upstream changes (presumably #2660) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants