Skip to content

Bump ember-router-scroll from 2.0.2 to 3.3.3 #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Aug 2, 2020

Bumps ember-router-scroll from 2.0.2 to 3.3.3.

Changelog

Sourced from ember-router-scroll's changelog.

Changelog

  • Updating to th v3.0 series was due to removing scrollWhenPainted as a config option. Also, we fixed some hidden bugs with scheduling when to scroll to your last y position.

3.3.0

  • #246 Add Evented trigger didScroll

3.2.0

  • #244 Bring back scroll recursive

3.1.3

  • #242 Unique functions to scheduleOnce...follow up
  • #241 Prevent multiple calls on routeDidChange
  • #240 Missing setter for scrollWhenAfterRender

3.1.0

  • #239 Scroll when afterRender

3.0.0

  • #238 Upgrade ember-app-scheduler to v4.0.0

2.0.1

  • #237 Remove recursive scroll check

2.0.0

  • #234 [MAJOR] Class based elements
  • #202 Update to 3.12

1.3.3

  • #225 Allow recording position with users first page visit
  • #223 Remove unnecessary part of code sample

1.3.2

1.3.1

  • #217 Dont batch reads and writes in same rAF

1.3.0

  • #217 Recursively check document height before scrollTo

1.2.1

  • #212 Allow configure so consuming app can override
  • #210 Fix query-params-only transitions

1.2.0

  • #209 Restore necessary locationType
  • #207 Remove ember-getowner-polyfill
  • #206 Improve the deprecation notice
  • #198 fix preserveScrollPosition for ember 3.6+
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@rust-highfive
Copy link

r? @locks

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Aug 3, 2020

☔ The latest upstream changes (presumably #2667) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.3 branch from f20a726 to 51e8568 Compare August 3, 2020 20:43
@bors
Copy link
Contributor

bors commented Aug 3, 2020

☔ The latest upstream changes (presumably #2672) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.3 branch 2 times, most recently from e77590d to 2b7f5d5 Compare August 10, 2020 13:51
@bors
Copy link
Contributor

bors commented Aug 10, 2020

☔ The latest upstream changes (presumably #2680) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.3 branch from 2b7f5d5 to c423fc7 Compare August 10, 2020 14:11
@bors
Copy link
Contributor

bors commented Aug 16, 2020

☔ The latest upstream changes (presumably #2690) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-router-scroll-3.3.3 branch from c423fc7 to e7d79de Compare August 16, 2020 07:55
@Turbo87 Turbo87 closed this Aug 16, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/ember-router-scroll-3.3.3 branch August 16, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants