Skip to content

Replace "Loading..." screen with progress bar at the top of the page #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Replace "Loading..." screen with progress bar at the top of the page #2481

wants to merge 2 commits into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 1, 2020 •
edited
Loading

@pichfl
Copy link

pichfl commented May 2, 2020

How this this hold up in terms of accessibility? Is this announced in some way?

@Turbo87
Copy link
Member Author

Turbo87 commented May 2, 2020

@pichfl to be honest, I have no idea... I know that there are aria attributes for progressbars, but I'm not aware of the addon using those. do you consider this a blocker or is this something we could retrofit later?

@pichfl
Copy link

pichfl commented May 3, 2020

If you get around to refactoring that Addon, please consider adding some improvements. Until then, the new state is not worse than the old.

@bors r+

@bors
Copy link
Contributor

bors commented May 3, 2020

📌 Commit c0d87fe has been approved by pichfl

@bors
Copy link
Contributor

bors commented May 3, 2020

⌛ Testing commit c0d87fe with merge 89d6c98...

bors added a commit that referenced this pull request May 3, 2020
@bors
Auto merge of #2481 - Turbo87:progress, r=pichfl
89d6c98 
Replace "Loading..." screen with progress bar at the top of the page

<img width="1440" alt="Bildschirmfoto 2020-05-01 um 19 15 46" src="https://user-images.githubusercontent.com/141300/80825365-80ea5f00-8be0-11ea-9717-6ad6f476a00b.png">

Implemented via https://github.com/tigressbailey/ember-cli-page-progress

r? @pichfl
@bors
Copy link
Contributor

bors commented May 3, 2020

💔 Test failed - checks-travis

@locks
Copy link
Contributor

locks commented May 5, 2020

I am not a huge fan of progress bars in general (they're usually "lies" 😂), I'd prefer a Knight Rider-stylye spinner to indicate activity, but even then I'm more of a fan of your approach on the index page ;)

@bors
Copy link
Contributor

bors commented May 11, 2020

☔ The latest upstream changes (presumably #2505) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 12, 2020

closing this for now until we find a solution 😢

@Turbo87 Turbo87 closed this Jun 12, 2020
@Turbo87 Turbo87 mentioned this pull request Jun 12, 2020
Merged
bors added a commit that referenced this pull request Jun 15, 2020
@bors
Auto merge of #2571 - Turbo87:progress2, r=locks
b8c6986 
Replace "Loading" template with progress bar

similar to #2481, but this time with a custom implementationt that shouldn't break the tests 😅

r? @locks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Turbo87 Turbo87

@pichfl pichfl

Labels
A-frontend 🐹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turbo87 @pichfl @bors @locks @rust-highfive