Skip to content

Replace "Loading" template with progress bar #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 12, 2020

similar to #2481, but this time with a custom implementationt that shouldn't break the tests 😅

r? @locks

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 12, 2020
@Turbo87 Turbo87 force-pushed the progress2 branch 3 times, most recently from 59ba578 to b980793 Compare June 15, 2020 08:10
@locks
Copy link
Contributor

locks commented Jun 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 15, 2020

📌 Commit af6e7ec has been approved by locks

@bors
Copy link
Contributor

bors commented Jun 15, 2020

⌛ Testing commit af6e7ec with merge b8c6986...

@bors
Copy link
Contributor

bors commented Jun 15, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing b8c6986 to master...

@bors bors merged commit b8c6986 into rust-lang:master Jun 15, 2020
@Turbo87 Turbo87 deleted the progress2 branch June 15, 2020 18:02
Turbo87 added a commit to Turbo87/skylines that referenced this pull request Jun 22, 2020
Turbo87 added a commit to Turbo87/skylines that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants