Use custom emberjs buildpack #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently this is not the correct way to include the buildpack. I should have read the usage section:
|
It appears that the buildpack we were grabbing from S3 is very stale. That version pins `heroku/nodejs-v98` which is also old (the current version is v174). This is causing deploys to fail and has already been [reported] upstream. This commit pins to a custom built version based on jtgeibel/heroku-buildpack-emberjs@get-things-building. [reported]: heroku/heroku-buildpack-emberjs#61
jtgeibel
force-pushed
the
update-emberjs-buildpack
branch
from
279caa2 to
d83f0e1
Compare
|
I've got deploys working again by updating the buildpack so that it compiles again, and manually building a new We should switch back once upstream does a new release, but this unblocks our deploys for now. @bors r+ |
|
📌 Commit d83f0e1 has been approved by |
|
☀️ Test successful - checks-travis |
jtgeibel
changed the title
jtgeibel
added a commit
to jtgeibel/crates.io
that referenced
this pull request
Sep 20, 2020
Since rust-lang#2657 we build the frontend twice during a deploy. It seems that the nodejs buildpack (pulled in by the emberjs buildpack) is running our build script so lets just depend on that directly because it is actively supported by Heroku.
bors
added a commit
that referenced
this pull request
Sep 20, 2020
…itor Use nodejs buildpack directly (instead of via the emberjs buildpack) Since #2657 we build the frontend twice during a deploy. It seems that the nodejs buildpack (pulled in by the emberjs buildpack) is running our build script so lets just depend on that directly because it is actively supported by Heroku. r? `@JohnTitor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the buildpack we were grabbing from S3 is very stale.
That version pins
heroku/nodejs-v98which is also old (the currentversion is v174).
This is causing deploys to fail and has already been reported
upstream. This commit pins to a custom built version based on
jtgeibel/heroku-buildpack-emberjs@34f4175.
I'm trying a staging deploy of this now, and will merge once that succeeds.
r? @ghost