Cleanup unneeded lints and drop unused Debug impls

[jtgeibel]

The lib crate is only used by other in-tree crates. Therefore if Debug
or Copy impls are ever needed, they can be easily added.

82 unused Debug impls are then dropped. This probably has a slight but
negligible improvement to compile/link times.

r? @Turbo87

[Turbo87]

hmmm..... I like the first two commits of the PR, but I'm not sure about the third one that is dropping all of the existing Debug traits. They might not be used right now, but they make it slightly easier to debug while developing. Unless the build time improvement is significant I think I'd prefer to keep them 🤔

@pietroalbini any thoughts on this?

[jtgeibel]

@Turbo87 yeah I was a bit split on the final commit myself. I think it might be worth dropping the Debug impls and adding them back as they prove useful for debugging. I suspect a lot of these were added just to satisfy the lint. For example, I doubt the Debug impls on view structs is very useful, since the purpose of these is to implement Serialize for generating response data (which is already easily inspectable).

However, I definitely have no concern with dropping the 3rd commit either. I don't think it would be worth the effort to go through the list of structs to analyze them ahead of time, and would gladly drop the commit from this series if that is preferred.

[pietroalbini]

Forced Debug is annoying when there are structs with fields that don't support Debug themselves, so I agree with removing the lint. I'd also check for manual impls of Debug that could be removed, I think I added a few of them myself.

[Turbo87]

I've rebased and dropped the third commit for now (still available as jtgeibel@2c80e6b) :)

@bors r+

[bors]

📌 Commit a891c24 has been approved by Turbo87

[bors]

⌛ Testing commit a891c24 with merge 1168fd7...

[bors]

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 1168fd7 to master...