Sentry: Improve metadata collection #4115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `add_custom_metadata()` This allows us to add the metadata to issue reports as soon as possible, instead of only doing it in the `after()` method of the middleware.
…before()` method This allows us to add the metadata to issue reports as soon as possible, instead of only doing it in the `after()` method of the middleware.
Turbo87
added
C-internal 🔧
JohnTitor
approved these changes
Nov 3, 2021
|
@bors r+ |
|
📌 Commit a2945a4 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
request.idtag and the "custom metadata" are currently only assigned to the Sentry scope in theafter()method of theLogRequestmiddleware. This means that for any manualsentry::capture_exception()call these fields will not be set correctly.This PR moves the
configure_scope()calls into thebefore()method andadd_custom_metadata()function instead. This allows us to send the fields to Sentry for error reports as soon as they are available.