middleware::log_request: Split request timing code into dedicated middleware #4116
+86
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
☔ The latest upstream changes (presumably #4115) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
timing-middleware
branch
from
16cda83 to
fd05665
Compare
Turbo87
force-pushed
the
timing-middleware
branch
from
fd05665 to
775a75a
Compare
JohnTitor
reviewed
Nov 3, 2021
Comment on lines
+155
to
+158
| if let Some(response_time) = response_time { | ||
| if response_time.as_millis() > SLOW_REQUEST_THRESHOLD_MS { | ||
| line.add_marker("SLOW REQUEST")?; | ||
| } |
There was a problem hiding this comment.
We could de-duplicate this if let by merging it into the above if let or binding response_time.
There was a problem hiding this comment.
the problem with merging them is that it changes the field order
There was a problem hiding this comment.
Ah, I see, then it should be fine. Thanks for clarifying!
JohnTitor
approved these changes
Nov 3, 2021
|
@bors r+ |
|
📌 Commit 775a75a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generic and not strictly related to the
LogRequestmiddleware. TheUpdateMetricsmiddleware should probably also use this in the future.