models/krate: Split create_or_update() fn into create() and update()
#7191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `create_or_update()` in the test suite we usually only really want `create()` without any unintentional updates.
Turbo87
added
C-internal 🔧
0xPoe
approved these changes
Sep 27, 2023
LawnGnome
reviewed
Sep 27, 2023
LawnGnome
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to simplify the
NewCrate::create_or_update()fn, by splitting up into two more straight-forwardcreate()andupdate()fns. This allows us to explicitly use onlycreate()in our test suite code, and a combination of both in the publish endpoint.