Skip to content

models/version: Move license validation into publish endpoint #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 27, 2023

We don't need to run the validation when we create versions for unit test purposes, and moving it to the publish endpoint allows us to combine this validation with other validation steps already performed in this part of the codebase.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 27, 2023
@bors
Copy link
Contributor

bors commented Sep 27, 2023

☔ The latest upstream changes (presumably #7191) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 merged commit 482ed93 into rust-lang:main Sep 27, 2023
@Turbo87 Turbo87 deleted the license-validation branch September 27, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants