worker: Replace r2d2 with deadpool
#8385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
deadpool-worker
branch
2 times, most recently
from
1f55578 to
e9b0c9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8385 +/- ##
==========================================
- Coverage 87.64% 87.62% -0.03%
==========================================
Files 272 272
Lines 26342 26333 -9
==========================================
- Hits 23087 23073 -14
- Misses 3255 3260 +5 ☔ View full report in Codecov by Sentry. |
LawnGnome
approved these changes
Apr 2, 2024
Comment on lines
+352
to
+355
| let already_processed = conn | ||
| .interact(move |conn| already_processed_inner(path, conn)) | ||
| .await | ||
| .map_err(|err| anyhow!(err.to_string()))??; |
There was a problem hiding this comment.
Is it worth us providing a trait to wrap this pattern, since it's coming up in every job?
There was a problem hiding this comment.
you mean something like .interact_anyhow(...)?
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports all of our background worker jobs to use the async database connection pool (based on the
deadpoolcrate) instead ofr2d2(which does not supportdiesel-async).This was initially causing failing and flaky tests, but those issues got resolved by: