Skip to content

controllers: Replace r2d2 with deadpool #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 9, 2024
Merged

controllers: Replace r2d2 with deadpool #8431

merged 22 commits into from
Apr 9, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 9, 2024

This PR is roughly similar to #8385, but this time all of our API endpoints are ported from the sync r2d2 database connection pool to the async deadpool equivalent.

A couple of minor refactorings were needed in some places, but the semantics should still be similar to before. I guess this is best reviewed commit-by-commit... 😅

Turbo87 added 22 commits April 9, 2024 18:28
@Turbo87
controllers/category: Replace r2d2 with deadpool
d0d6f8f
@Turbo87
controllers/crate_owner_invitation: Replace r2d2 with deadpool
c5969f4
@Turbo87
controllers/github/secret_scanning: Replace r2d2 with deadpool
e4bd0a6
@Turbo87
controllers/keyword: Replace r2d2 with deadpool
53d11dc
@Turbo87
controllers/krate/downloads: Replace r2d2 with deadpool
8327540
@Turbo87
controllers/krate/follow: Replace r2d2 with deadpool
199c5a2
@Turbo87
controllers/krate/metadata: Replace r2d2 with deadpool
95f6e99
@Turbo87
controllers/krate/owners: Move spawn_blocking() call into `modify_o…
1f2c60e 
…wners()` fn
@Turbo87
controllers/krate/owners: Replace r2d2 with deadpool
42b5380
@Turbo87
controllers/krate/publish: Replace r2d2 with deadpool
a7991ef
@Turbo87
controllers/krate/search: Replace r2d2 with deadpool
c88365e
@Turbo87
controllers/krate/versions: Replace r2d2 with deadpool
b7b9d70
@Turbo87
controllers/metrics: Move spawn_blocking() calls into match arms
4903ac9
@Turbo87
controllers/metrics: Replace r2d2 with deadpool
c5b8e3f
@Turbo87
controllers/summary: Replace r2d2 with deadpool
913f895
@Turbo87
controllers/token: Replace r2d2 with deadpool
740bf53
@Turbo87
controllers/user/me: Replace r2d2 with deadpool
8f965c8
@Turbo87
controllers/user/other: Replace r2d2 with deadpool
dbf4345
@Turbo87
controllers/version/downloads: Replace r2d2 with deadpool
ec052df
@Turbo87
controllers/version/metadata: Replace r2d2 with deadpool
c6556eb
@Turbo87
controllers/version/yank: Move spawn_blocking() call into `modify_y…
3aa42e7 
…ank()` fn
@Turbo87
controllers/version/yank: Replace r2d2 with deadpool
424775b
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Apr 9, 2024
@Turbo87 Turbo87 requested a review from a team April 9, 2024 16:31
LawnGnome
LawnGnome approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 browser tabs later, 👍.

@Turbo87 Turbo87 merged commit 3d19e1c into rust-lang:main Apr 9, 2024
@Turbo87 Turbo87 deleted the deadpool-controllers branch April 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawnGnome LawnGnome LawnGnome approved these changes

Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @LawnGnome