Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Move infobox headers from left to above #13

Merged
merged 1 commit into from
Oct 14, 2013
Merged

Move infobox headers from left to above #13

merged 1 commit into from
Oct 14, 2013

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented Oct 14, 2013

On my display, the code is long enough that it wraps, which is ugly.
We could just make the code shorter, but there's a better solution.
The low-resolution responsive view puts the infobox headers above,
rather than to the left, which not only wastes less space but also
just plain looks better. So let's just do that on the high-res view.

On my display, the code is long enough that it wraps, which is ugly.
We could just make the code shorter, but there's a better solution.
The low-resolution responsive view puts the infobox headers *above*,
rather than to the left, which not only wastes less space but also
just plain looks better. So let's just do that on the high-res view.
brson added a commit that referenced this pull request Oct 14, 2013
Move infobox headers from left to above
@brson brson merged commit db56e91 into rust-lang:gh-pages Oct 14, 2013
@adrientetar
Copy link
Contributor

@bstrie Out of curiosity, what is your screen resolution? On Firefox? I do a lot of web dev. these days but I'm still kind of a newbie esp. for responsive design questions and I thought it was cut up to the right width. :/
Now I know rendering differs from one computer to another... (OS, fonts installed etc. etc.) pretty scary for someone doing web dev!
On the design question, I see that people (namely you and @Seldaek) didn't like the right-aligned text. Have you considered stacking it to the table on large res but left-aligned (as it was before my changes)?
Personally, I thought it looked good that way and it looks to me like that the column is just too wide the way it is currently on 1200px+ w. Think it might be possible to use col-lg-* classes (or well just md with media query) to have it stacked on large res. [1]
What do you think?
BTW, if you send another patch, I see that you have indent with spaces and I reindented it all with tabs last time so.. we need have that normalized. ;)

EDIT: [1] .boxhead h2 { margin-top: 10px; }.

@bstrie
Copy link
Contributor Author

bstrie commented Oct 15, 2013

To be honest, having the titles scrunched up in their own mostly-empty column has been a peeve of mine for a while. Seeing the small-res view put them on top was just the kick I needed to do something about it. Didn't have anything to do with text alignment.

As for more concrete questions of design... I dunno! Piecemeal design like what the three of us are doing doesn't really scale. If you have something that you think looks good, host the repo somewhere and let brson be the final decider of whether or not to accept it.

@adrientetar
Copy link
Contributor

I see, well I meant like before ~ w/10px margin: http://adrientetar.legtux.org/cached/rust-www/
Think it was a bit more compact & easy to focus on, no biggies through of course.

PS: on a side note, I like the overall design of the website. It's simple, clean and useful (esp. if you compare it with other programming languages homepages that are either too complicated/cluttered or just make marketing, programmers don't need marketing). Earlier this year I was hesitating between D and Rust and of course I didn't choose Rust because of its website but it's something that, when it's nicely done really gives you the lust to learn more imo (not that D homepage is any bad, just that Rust website is simpler and better to look at).

@bstrie
Copy link
Contributor Author

bstrie commented Oct 15, 2013

That modification still causes the code to wrap on my screen. Again, we could manually break that line at the comma... but it's just 78 characters, which isn't egregiously long in the first place, and I think putting the headers above the box is a better-looking solution anyway (to reiterate, my peeve is the way the wrapped text in the leftmost columns looks, rather than any complaint about padding). My screen is more than large enough for resolution to not be a factor, zoom level is normal, and it happens in all the browsers I try.

Do you have the Monaco font installed? If not, that could explain why you don't observe this behavior on your end.

@adrientetar
Copy link
Contributor

You're right, I use Consolas (great one!) but Monaco is wide and same with Menlo (found this BTW). If you're ok with that change I will send a patch to fix the width problem and go back to the previous layout scheme on large res then.

adrientetar added a commit to adrientetar/rust-www that referenced this pull request Oct 15, 2013
As discussed on rust-lang#13, this goes back to the original layout, namely side
titles on large res, but aligns them to the left and gives enough spacing
to display the code snippets with large monospaced fonts (e.g Monaco,
Menlo).
@adrientetar
Copy link
Contributor

@bstrie I have updated my cached copy in case you want to check it out. Now the table and code both use .col-md-10 (resized to 20%) instead of .col-md-9.

brson pushed a commit that referenced this pull request Dec 22, 2016
steveklabnik pushed a commit that referenced this pull request May 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants