-
Notifications
You must be signed in to change notification settings - Fork 340
There are something new in Chinese translation. #578
The head ref may contain hidden characters: "\u4E2D\u658716.10.14"
Conversation
16.10.12.18.8
16.10.14.9.40
(rust_highfive has picked a reviewer for you, use r? to override) |
@@ -9,12 +9,11 @@ | |||
<div class="row install"> | |||
<div class="col-md-4 side-header"> | |||
<h2 id="stable">{{ site.stable }} </h2> | |||
<h3>{{ site.stable_date | date: "%B %-d, %Y" }}</h3> | |||
<h3>{{ site.stable_date | date: "%Y 年 %m 月 %-d 日" }}</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be %Y年%-m月%-d日
, like "2017年1月1日" or "2017年1月15日"? That is, no leading zero, and no space inbetween. Also, site.beta_date
remains untranslated.
(Tip: If you want weekdays as well, you can make use of arrays as previously used by pt-BR
. Liquid's support of array is at best strange, though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Chinese there need a space between (number or letter )and (chinese words)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't need weekdays as well,%m mean month,
and I don't know what mean about site.beta_date
@lifthrasiir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3442853561 My impression from various Chinese websites was that there are no spaces between numbers and Chinese letters, but if you say a space is in fact needed, I'm okay with that.
%m
will always display two digits for month. %Y 年 %m 月 %-d 日
will give you "2017 年 01 月 1 日" for example, which looks strange.
On site.beta_date
, there are two dates for the latest stable release and the upcoming stable release (which is currently at beta). You will want to translate both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifthrasiir THX,I fixed it.
@@ -213,7 +212,7 @@ the [Rust security disclosure process](security.html). | |||
{% assign sitename = "github" %} | |||
{% endif %} | |||
{% assign site = page.sites[sitename] %} | |||
<li class="person {% if team.lead and team.lead == nick %}lead{% endif %}"> | |||
<li class="person {% if team.lead and team.lead == nick %}负责人{% endif %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a CSS class and should not be translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifthrasiir fixed
Thanks! |
一些中文翻译的新玩意儿