Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Translate new install.html to pt-BR #637

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Translate new install.html to pt-BR #637

merged 1 commit into from
Dec 19, 2016

Conversation

leoyvens
Copy link
Contributor

Translation to pt-BR of the new install.html. I'm feeling lazy about translating other-installers.md so if anyone wants to pick that up feel free. Also snuck some minor adjustments. Pinging @lazpeng for review.

@rust-highfive
Copy link

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@lazpeng
Copy link
Contributor

lazpeng commented Dec 17, 2016

Nice.
Should have a comma after "English" in "Nosso site em outros idiomas", located in _layouts/pt-BR/basic.html, if you could fix that and add it to the PR, I'd be very grateful. Also, "executar" may be better than "rodar", what do you think?

@leoyvens
Copy link
Contributor Author

Made suggested changes. In some places "rodar" seems better in others "executar" seems better, I changed it in some places, what do you think now?

@lazpeng
Copy link
Contributor

lazpeng commented Dec 18, 2016

Yeah, that's better, thanks.

@aturon
Copy link
Member

aturon commented Dec 19, 2016

r? @steveklabnik

In general, how would you like to handle ongoing reviews of translation PRs?

@rust-highfive rust-highfive assigned steveklabnik and unassigned aturon Dec 19, 2016
@steveklabnik
Copy link
Member

In general, how would you like to handle ongoing reviews of translation PRs?

Usually, I try to check up on rust-www at least once a week to batch it up a bit. It's been a complicated last couple of weeks though. Often, I'll try to CC the people who made the original translation onto changes if they're more than something tiny, but at the moment, the process is effectively 100% trust based.

@steveklabnik steveklabnik merged commit 3257bbb into rust-lang:master Dec 19, 2016
@steveklabnik
Copy link
Member

(in this case, @lazpeng is the person I'd want to ask here, so let's merge!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants