fix: Insert type vars in function arguments #14897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
HKalbasi
commented
May 26, 2023
Comment on lines
+1684
to
+1688
| let coercion_target = self.insert_type_vars(coercion_target); | ||
| if self.coerce(Some(arg), &ty, &coercion_target).is_err() { |
There was a problem hiding this comment.
Is this correct? I think we shouldn't emit type mismatch in this case:
fn foo(x: Vec<Unknown>) {
}
foo(vec![1, 2, 3]);So this is correct. But it feels like it was intentionally the way it was. Maybe it has performance consideration?
There was a problem hiding this comment.
Yeah I think this is correct thing to do. Can you comment that we insert type vars to avoid reporting that kind of type mismatches?
Also, can you add a test that does emit type mismatch when we fail to coerce even after this change? Something like
fn foo(x: Vec<Unknown>) {}
fn test() {
foo(42);
//^^ type mismatch here
}
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
|
This fixed the type mismatches regression on webrender. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #14891