Skip to content

Ignore unfulfilled_lint_expectations in metadata collection #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022

Conversation

Alexendoo
Copy link
Member

r? @xFrednet

When metadata collection is enabled the regular early/late pass registrations are skipped, which the #[expect()]s were no fan of: https://github.com/rust-lang/rust-clippy/runs/6356675328?check_suite_focus=true

changelog: none

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 9, 2022
@xFrednet
Copy link
Member

xFrednet commented May 9, 2022

Ahh, you're right, nice quick catch. Thank you very much! ❤️

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2022

📌 Commit 6edf0b4 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented May 9, 2022

⌛ Testing commit 6edf0b4 with merge 77effb7...

@bors
Copy link
Contributor

bors commented May 9, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 77effb7 to master...

@bors bors merged commit 77effb7 into rust-lang:master May 9, 2022
@xFrednet
Copy link
Member

xFrednet commented May 9, 2022

Now everything is green again 🎉

@Alexendoo Alexendoo deleted the metadata-collection-expect branch May 9, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants