Skip to content

Ignore unfulfilled_lint_expectations in metadata collection #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022
Merged

Ignore unfulfilled_lint_expectations in metadata collection #8809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/dogfood.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ fn dogfood_clippy() {

// "" is the root package
for package in &["", "clippy_dev", "clippy_lints", "clippy_utils", "rustc_tools_util"] {
run_clippy_for_package(package);
run_clippy_for_package(package, &[]);
}
}

Expand All @@ -38,7 +38,7 @@ fn run_metadata_collection_lint() {

// Run collection as is
std::env::set_var("ENABLE_METADATA_COLLECTION", "1");
run_clippy_for_package("clippy_lints");
run_clippy_for_package("clippy_lints", &["-A", "unfulfilled_lint_expectations"]);

// Check if cargo caching got in the way
if let Ok(file) = File::open(metadata_output_path) {
Expand All @@ -61,10 +61,10 @@ fn run_metadata_collection_lint() {
.unwrap();

// Running the collection again
run_clippy_for_package("clippy_lints");
run_clippy_for_package("clippy_lints", &["-A", "unfulfilled_lint_expectations"]);
}

fn run_clippy_for_package(project: &str) {
fn run_clippy_for_package(project: &str, args: &[&str]) {
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));

let mut command = Command::new(&*test_utils::CARGO_CLIPPY_PATH);
Expand All @@ -76,6 +76,7 @@ fn run_clippy_for_package(project: &str) {
.arg("--all-targets")
.arg("--all-features")
.arg("--")
.args(args)
.args(&["-D", "clippy::all"])
.args(&["-D", "clippy::pedantic"])
.arg("-Cdebuginfo=0"); // disable debuginfo to generate less data in the target dir
Expand Down