This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Properly warn if a package lacks [lib] target #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it errors out with a "lost build artifact", which may be hard to decipher.
Xanewok
force-pushed
the
no-lib-target
branch
from
cc885b4 to
6a9daf8
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it errors out with a "lost build artifact", which may be hard to decipher.
Discovered this when running
cargo semveron a package that is only a binary - while it seems obvious (there's no public crate API in the first place), the original error message left me wondering if there is something wrong with the build artifact (e.g. internal logic error or multiplecargoinstances running for the same target). Hopefully, this will make it more clear that it only works on a package with[lib]target.cc @ibabushkin
r? @Manishearth